Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Bump version to the next release version 2.8.0 #13368

Merged
merged 1 commit into from
May 3, 2023
Merged

chore: Bump version to the next release version 2.8.0 #13368

merged 1 commit into from
May 3, 2023

Conversation

anandf
Copy link
Contributor

@anandf anandf commented Apr 28, 2023 •
edited
Loading

Minor change to bump the version number in master branch to the next release.
Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.

Please see Contribution FAQs if you have questions about your pull-request.

@anandf
Bumped version to the next release version 2.8.0
b276c5d 
Signed-off-by: anandf <anjoseph@redhat.com>
@anandf anandf changed the title Bumped version in master branch to the next release version 2.8.0 chore: Bumped version in master branch to the next release version 2.8.0 Apr 28, 2023
@codecov
Copy link

codecov bot commented Apr 28, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (03513eb) 49.06% compared to head (b276c5d) 49.06%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #13368      +/-   ##
==========================================
- Coverage   49.06%   49.06%   -0.01%     
==========================================
  Files         248      248              
  Lines       42816    42816              
==========================================
- Hits        21009    21006       -3     
- Misses      19688    19690       +2     
- Partials     2119     2120       +1

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@anandf anandf changed the title chore: Bumped version in master branch to the next release version 2.8.0 chore: Bump version in master branch to the next release version 2.8.0 Apr 28, 2023
@anandf anandf changed the title chore: Bump version in master branch to the next release version 2.8.0 chore: Bump version to the next release version 2.8.0 Apr 28, 2023
@drpaneas
Copy link
Contributor

Shouldn't this be automated by a bot or something? Also there are multiple ways to embed the version nowadays into the build without the need of the VERSION file. https://developers.redhat.com/articles/2022/11/14/3-ways-embed-commit-hash-go-programs

34fathombelow
34fathombelow approved these changes May 2, 2023
View reviewed changes
Copy link
Member

@34fathombelow 34fathombelow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thanks! This is actually automated now in our new release process.

@34fathombelow 34fathombelow mentioned this pull request May 2, 2023
Closed
jannfis
jannfis approved these changes May 3, 2023
View reviewed changes
Copy link
Member

@jannfis jannfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jannfis jannfis enabled auto-merge (squash) May 3, 2023 14:41
@jannfis jannfis merged commit c5f49e1 into argoproj:master May 3, 2023
@anandf anandf deleted the bump_version branch August 3, 2023 12:59
yyzxw pushed a commit to yyzxw/argo-cd that referenced this pull request Aug 9, 2023
@anandf
chore: Bumped version to the next release version 2.8.0 (argoproj#13368)
c59a115 
Signed-off-by: anandf <anjoseph@redhat.com>
@anandf anandf mentioned this pull request Nov 6, 2024
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@34fathombelow 34fathombelow 34fathombelow approved these changes

@jannfis jannfis jannfis approved these changes

Assignees
No one assigned
Labels
ready-for-review
Projects
Argo CD Review
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@anandf @drpaneas @jannfis @34fathombelow